Completion detail using module name, function parameters #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tomv564 thanks for this, I like it! Much more useful IMO. Happy to merge once tests pass. |
Contributor
|
@tomv564 think you need [edit] ahh, it's a py2 vs py3 thing |
gatesn
reviewed
Oct 28, 2017
pyls/plugins/completion.py
Outdated
|
|
||
| def _label(definition): | ||
| if definition.type in ('function', 'method'): | ||
| params = ", ".join(map(lambda definition: definition.name, definition.params)) |
Contributor
There was a problem hiding this comment.
Also, could you use a list comprehension instead of the map builtin.
gatesn
reviewed
Oct 28, 2017
test/plugins/test_completion.py
Outdated
|
|
||
| assert len(items) > 0 | ||
| assert items[0]['label'] == 'read' | ||
| assert items[0]['label'] == 'read()' |
Contributor
There was a problem hiding this comment.
Doesn't make sense to try and deal with 2vs3 (I believe python 3 lets you "inspect" the python * and ** parameters to a function), so you may want to just pick another builtin to test against instead of sys.stdin.read !
Contributor
Author
There was a problem hiding this comment.
Tried sys.exit which also differed, for now I added the version check inline.
I can try a few more later, agree it is clumsy logic to have in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some explorations for #149 for testing / discussion. Likely to conflict with the Rope integration, but this is far from decided anyways.
Performance is okay for me in a small codebase, anyone working with a large code base who can do a quick comparison?
References to Jedi implementations:
Signature params: https://github.com/davidhalter/jedi/blob/752b7d8d495689a38076f20475a870f8aa139a28/jedi/api/classes.py#L314
Full_name:
https://github.com/davidhalter/jedi/blob/752b7d8d495689a38076f20475a870f8aa139a28/jedi/api/classes.py#L265