Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Sep 29, 2017

Fixes #144

@gatesn gatesn merged commit 91b5e4e into develop Sep 29, 2017
@gatesn gatesn deleted the ngates/pycodestyle-options branch September 29, 2017 21:19
@lgeiger
Copy link
Contributor

lgeiger commented Sep 30, 2017

Thanks a lot for the super fast fix, this is awesome.

Though I feel like the config from files like setup.cfg should take precedence over the global config defined in the VSCode settings. This way people can very easily switch between projects that don't have specific pycodestyle configs (and therefor use the defaults set in the VSCode config) and still have projects with custom configs. What do you think?

@gatesn
Copy link
Contributor Author

gatesn commented Sep 30, 2017 via email

@lgeiger
Copy link
Contributor

lgeiger commented Oct 1, 2017

Thanks a lot for the thorough explanation of your train of thought!

I'm seeing the IDE settings as a replacement for the user configs (files in a user’s home directory) in order to give not very technical people an easy and fast way of configuring the linting behavior for projects with no custom style guide defined in a project config.

Generally speaking I don't think it's a particular good thing to give people the possibility to overwrite project configs. In some cases it can eliminate the benefit of having a project config in, being that it removes the nitpicking about code style in code reviews.

Are there any precedents in this space?

linter-flake8 and prettier both use the IDE configuration only as a fallback when no project configs are found.

@lgeiger
Copy link
Contributor

lgeiger commented Oct 3, 2017

Would you be interested in a PR implementing the behavior above?

@gatesn gatesn mentioned this pull request Oct 3, 2017
@gatesn
Copy link
Contributor Author

gatesn commented Oct 3, 2017

@lgeiger could you review #156 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.