Thanks for your interest in palantir/python-language-server, @lgeiger! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

I’m not opposed to turning this on by default if you think it makes sense?

Wonder if we can get a better list of symbols though, as this seems to include method parameters.

@lgeiger thanks very much for this! Looks good. If you could change the default to true (not too fussed about changing existing behaviour since we're still pre-1.x), then I'd be happy to merge this.

Sorry for the late reply.

Wonder if we can get a better list of symbols though, as this seems to include method parameters.

Unfortunately this seams to be jedi's fault. When calling jedi_names with all_scopes=false on:

def test(param1, param2):
    pass

It also returns both test, param1 and param2.

@lgeiger thanks very much for this! Looks good. If you could change the default to true (not too fussed about changing existing behaviour since we're still pre-1.x), then I'd be happy to merge this.

👍 I'll change that.

I've been experimenting with properly structuring the symbols using containerName but I'm getting strange UI behavior in conjunction with Atom's language server plugin. I'll submit another PR once I know if the bug is inside my code or comes from Atom's language server plugin.