Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Sep 3, 2017

Fixes #57

TODO:

  • Provide a pyls hook for plugins to return default configuration
  • Allow loading configuration from disk / "ini" files?
  • Figure out if VSCode / clients more generally are supposed to send full settings, or diffs - VSCode sends the full settings block

@gatesn
Copy link
Contributor Author

gatesn commented Sep 4, 2017

@tomv564 do you know the answer to the third TODO in the PR description?

@tomv564
Copy link
Contributor

tomv564 commented Sep 4, 2017

It's probably easiest to send the whole settings block, the language can always do the diffing itself if needed.

@gatesn
Copy link
Contributor Author

gatesn commented Sep 4, 2017

I'll probably support recursive merging anyway to better support default configurations.

@gatesn gatesn merged commit aa8e1b2 into develop Sep 4, 2017
@gatesn gatesn deleted the ngates/config branch September 4, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.