bugfix effective system pair#347
Merged
johannes-moegerle merged 1 commit intopairinteraction:masterpairinteraction/pairinteraction:masterfrom Jan 19, 2026
johannes-moegerle:bugfix-eff-systemjohannes-moegerle/pairinteraction:bugfix-eff-systemCopy head branch name to clipboard
Merged
bugfix effective system pair#347johannes-moegerle merged 1 commit intopairinteraction:masterpairinteraction/pairinteraction:masterfrom johannes-moegerle:bugfix-eff-systemjohannes-moegerle/pairinteraction:bugfix-eff-systemCopy head branch name to clipboard
johannes-moegerle merged 1 commit intopairinteraction:masterpairinteraction/pairinteraction:masterfrom
johannes-moegerle:bugfix-eff-systemjohannes-moegerle/pairinteraction:bugfix-eff-systemCopy head branch name to clipboard
Conversation
|
seweber
approved these changes
Jan 19, 2026
b26b2b4
into
pairinteraction:master
24 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so far the effective system pair did not delete the cached model inds, which when using the same instance multiple times created unexpected results.
this is a simple fix for that problem.
However, I am not sure, whether one should look again into how the effective system class handles creation and deletion of attributes when using the same instance for different calculations to ensure no similar problems happen in the future.