Bump ImageSharp.Drawing to 1.0.0 #2099
Conversation
|
TODO:
|
|
TODO bits are done and tests all run; some examples are erroring but not sure if that's new. |
|
Need to think about why |
|
Only errors that seem to be generated now are related to missing fonts |
Jonarw
left a comment
There was a problem hiding this comment.
Other than the one TODO, looks good to me!
| public override OxySize MeasureText(string text, string? fontFamily = null, double fontSize = 10, double fontWeight = 500) | ||
| { | ||
| return this.MeasureTextLoose(text, fontFamily, fontSize, fontWeight); | ||
| // TODO: should fontFamily be nullable? |
There was a problem hiding this comment.
Were you able to come to a conclusion on this?
There was a problem hiding this comment.
The RenderErrorMessage logic leaves it null, which I presume is intentional to allow the render context to pick a simple font if there are rendering errors, or something like that. The example library is also full of null font families, so I don't think we can change it in a hurry. I did spot a bug, though, which I've lazily pushed as a small addition to this PR.
I was going to refit ImageSharp completely, but then I realised that ImageSharp.Drawing is fine with version 1.0.0 still, so this just bumps it so that it's not a beta version.
Checklist
Changes
@oxyplot/admins