Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@belucha
Copy link
Contributor

@belucha belucha commented Sep 12, 2023

  • add demonstration code
  • fix the problem, by correctly setting the index of the ValidItemsIndexInversion Dictionary

Fixes #2038

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

None.

@oxyplot/admins

- add demonstration code
- fix the problem, by correctly setting the index of the
  ValidItemsIndexInversion Dictionary
@VisualMelon
Copy link
Contributor

Fix looks good to me!

Very boring, but bug examples should be in the ExampleLibrary.Issues class (and in this case marked closed because it is fixed): can you move it to Issues and add a SubTitle explaining the expected behaviour so that when we come back to in future we can be sure the issue hasn't returned.

add some hints and improve documentation
@belucha
Copy link
Contributor Author

belucha commented Sep 12, 2023

@VisualMelon thanks for the fast reply. I've made the changes as requested.

Regards Daniel

@VisualMelon
Copy link
Contributor

All looks good to me; won't merge just yet so that the other maintainers have an opportunity to look it over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BarSeriesBase: HitTest does not deliver the correct BarItem, when there are invalid items in Data

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.