Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@VisualMelon
Copy link
Contributor

Fixes #1900 by adding properties to PathAnnotation that match the functionality of TextAnnotation. Decided to not try to put everything in TextualAnnotation because there would be naming issues, as the same names are used in PathAnnotation and TextAnnotation already for different purposes.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Add four new properties to PathAnnotation:
    • TextBackground
    • TextBackgroundStroke
    • TextBackgroundStrokeThickness
    • TextBackgroundPadding

@colejonson66 suggested Border for the stroke properties as an alternative to Background, which may be a better name.

@oxyplot/admins

@VisualMelon
Copy link
Contributor Author

ShapeAnnotation would be another candidate for adding such properties if we can settle on names.

@VisualMelon
Copy link
Contributor Author

@oxyplot/admins does this API look OK? Not wild about ChangeOpacity now that I look at it again, but can remove that and keep the other changes otherwise.

Any preference between Border/Background for naming per ermakrs from @colejonson66 ?

@Jonarw
Copy link
Member

Jonarw commented Jul 11, 2023

Border sounds more adequate at first, however the property TextBackground doesn't make sense when renamed to TextBorder. I guess we'd have to do TextBorderBackground then. TextBorderStroke, TextBorderStrokeThickness and TextBorderPadding would be fine however.

Currently I would tend to leaving it at Background, but could be convinced otherwise.

ChangeOpacity is fine in my opinion, ChangeAlpha could also work.

@VisualMelon
Copy link
Contributor Author

Looking at this quickly now, I'm tempted again by TextBorderStroke and TextBorderThickness, leaving everything else as is. If that's agreeable, then I'll make that change and I think we should get this merged.

@Jonarw
Copy link
Member

Jonarw commented Jul 22, 2023

Sounds good to me!

@VisualMelon
Copy link
Contributor Author

VisualMelon commented Jul 22, 2023

Then I don't like TextBackgroundPadding... I think TextBorderBackground is OK, so I've changed to Border everything (rather than TextBackground and rebased. I don't know if you're convinced by the new naming, however.

Copy link
Member

@Jonarw Jonarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine with me, if you're happy I think we can merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Background property is missing on PathAnnotations and Stoke properties are ignored

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.