-
Notifications
You must be signed in to change notification settings - Fork 985
Add PathAnnotation.TextBackground properties (#1900) #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@oxyplot/admins does this API look OK? Not wild about Any preference between |
|
Currently I would tend to leaving it at
|
|
Looking at this quickly now, I'm tempted again by |
|
Sounds good to me! |
|
Then I don't like |
Jonarw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine with me, if you're happy I think we can merge this :)
Fixes #1900 by adding properties to
PathAnnotationthat match the functionality ofTextAnnotation. Decided to not try to put everything inTextualAnnotationbecause there would be naming issues, as the same names are used inPathAnnotationandTextAnnotationalready for different purposes.Checklist
Changes proposed in this pull request:
PathAnnotation:TextBackgroundTextBackgroundStrokeTextBackgroundStrokeThicknessTextBackgroundPadding@colejonson66 suggested
Borderfor the stroke properties as an alternative toBackground, which may be a better name.@oxyplot/admins