Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Upgrade to .NET Core 3.1 (#1488) #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jonarw merged 1 commit into from
Mar 18, 2020
Merged

Upgrade to .NET Core 3.1 (#1488) #1489

Jonarw merged 1 commit into from
Mar 18, 2020

Conversation

@Jonarw
Copy link
Member

@Jonarw Jonarw commented Mar 3, 2020

Fixes #1488.
Also fixes #1483.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Update all netcoreapp3.0 targets to netcoreapp3.1
  • Change target order so net4xx targets are listed before netcoreapp3.x targets

Did I miss anything?

@oxyplot/admins

@Jonarw
Copy link
Member Author

Jonarw commented Mar 3, 2020

Azure Pipelines Build seems to fail for some reason... I don't really know what to do about this. @objorke could you take a look? Thanks!

@objorke
Copy link
Member

objorke commented Mar 3, 2020

The exceptions are thrown in a unit test in OxyPlot.Wpf.Tests
https://dev.azure.com/oxyplot/OxyPlot/_build/results?buildId=177&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=7bfb7e0f-549d-5929-c603-6e8046613b9e

The appveyor build seems to work:
https://ci.appveyor.com/project/objorke/oxyplot/builds/31204899

@Jonarw
Copy link
Member Author

Jonarw commented Mar 9, 2020

Is it actually a failed unit test? Yes, there is an exception thrown during testing, but no test is reported as failed... On my machine all test pass (except ExportPngAndCompareWithBaseline, but I guess that one is tricky anyway and does actually pass on Azure).

I don't really know what to do about this. Can we just ignore this error?

@Jonarw
Copy link
Member Author

Jonarw commented Mar 18, 2020

I am going to go ahead and merge this, considering that the AppVeyor build works fine.

@Jonarw Jonarw merged commit aee6661 into oxyplot:develop Mar 18, 2020
@Jonarw Jonarw deleted the update-target-platforms branch October 12, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to netcoreapp3.1 Change order of TargetFrameworks in OxyPlot.Wpf.csproj

2 participants

@Jonarw @objorke
Morty Proxy This is a proxified and sanitized view of the page, visit original site.