otovo
diff --git a/‎.pre-commit-config.yaml
Copy file name to clipboardExpand all lines: .pre-commit-config.yaml
+5-2Lines changed: 5 additions & 2 deletions b/‎.pre-commit-config.yaml
Copy file name to clipboardExpand all lines: .pre-commit-config.yaml
+5-2Lines changed: 5 additions & 2 deletions
diff --git a/‎portabletext_html/renderer.py
Copy file name to clipboardExpand all lines: portabletext_html/renderer.py
+1-1Lines changed: 1 addition & 1 deletion b/‎portabletext_html/renderer.py
Copy file name to clipboardExpand all lines: portabletext_html/renderer.py
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎tests/fixtures/invalid_node.json
Copy file name to clipboard
+13Lines changed: 13 additions & 0 deletions b/‎tests/fixtures/invalid_node.json
Copy file name to clipboard
+13Lines changed: 13 additions & 0 deletions
diff --git a/‎tests/fixtures/invalid_type.json
Copy file name to clipboard
+14Lines changed: 14 additions & 0 deletions b/‎tests/fixtures/invalid_type.json
Copy file name to clipboard
+14Lines changed: 14 additions & 0 deletions
diff --git a/‎tests/test_rendering.py
Copy file name to clipboardExpand all lines: tests/test_rendering.py
+15-1Lines changed: 15 additions & 1 deletion b/‎tests/test_rendering.py
Copy file name to clipboardExpand all lines: tests/test_rendering.py
+15-1Lines changed: 15 additions & 1 deletion
@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/ambv/black
-    rev: 21.12b0
+    rev: 22.3.0
     hooks:
       - id: black
         args: [ "--quiet" ]
@@ -19,7 +19,7 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://gitlab.com/pycqa/flake8
-    rev: 3.9.2
+    rev: 4.0.1
     hooks:
       - id: flake8
         additional_dependencies: [
@@ -34,6 +34,9 @@ repos:
             'flake8-printf-formatting',
             'flake8-type-checking',
         ]
+        args: [
+          '--allow-star-arg-any'
+        ]
   - repo: https://github.com/asottile/pyupgrade
     rev: v2.31.0
     hooks:
 
@@ -113,7 +113,7 @@ def _render_node(self, node: dict, context: Optional[Block] = None, list_item: b
             return self._custom_serializers.get(node.get('_type', ''))(node, context, list_item)  # type: ignore
 
         else:
-            if hasattr(node, '_type'):
+            if '_type' in node:
                 raise MissingSerializerError(
                     f'Found unhandled node type: {node["_type"]}. ' 'Most likely this requires a custom serializer.'
                 )
 
@@ -0,0 +1,13 @@
+{
+  "_key": "73405dda68e7",
+  "children": [
+    {
+      "_key": "25a09c61d80a",
+      "_type": "span",
+      "marks": [],
+      "text": "Otovo guarantee is good"
+    }
+  ],
+  "markDefs": [],
+  "style": "normal"
+}
@@ -0,0 +1,14 @@
+{
+  "_key": "73405dda68e7",
+  "_type": "invalid_type",
+  "children": [
+    {
+      "_key": "25a09c61d80a",
+      "_type": "span",
+      "marks": [],
+      "text": "Otovo guarantee is good"
+    }
+  ],
+  "markDefs": [],
+  "style": "normal"
+}
@@ -2,7 +2,9 @@
 import json
 from pathlib import Path
 
-from portabletext_html.renderer import render
+import pytest
+
+from portabletext_html.renderer import MissingSerializerError, UnhandledNodeError, render
 
 
 def load_fixture(fixture_name) -> dict:
@@ -45,3 +47,15 @@ def test_nested_marks():
     fixture = load_fixture('nested_marks.json')
     output = render(fixture)
     assert output == '<p><strong>A word of <em>warning;</em></strong> Sanity is addictive.</p>'
+
+
+def test_missing_serializer():
+    fixture = load_fixture('invalid_type.json')
+    with pytest.raises(MissingSerializerError):
+        render(fixture)
+
+
+def test_invalid_node():
+    fixture = load_fixture('invalid_node.json')
+    with pytest.raises(UnhandledNodeError):
+        render(fixture)
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ def _render_node(self, node: dict, context: Optional[Block] = None, list_item: b`
`113`	`113`	`return self._custom_serializers.get(node.get('_type', ''))(node, context, list_item) # type: ignore`
`114`	`114`
`115`	`115`	`else:`
`116`		`- if hasattr(node, '_type'):`
	`116`	`+ if '_type' in node:`
`117`	`117`	`raise MissingSerializerError(`
`118`	`118`	`f'Found unhandled node type: {node["_type"]}. ' 'Most likely this requires a custom serializer.'`
`119`	`119`	`)`