Add entitlements column to macOS signature table
#8666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entitlements are returned as JSON, or an empty string if no entitlements are set. Also added some integration testing to the table. fleetdm/fleet#25679
entitlements column to macOS signature table
lucasmrod
approved these changes
Aug 11, 2025
Comment on lines
+222
to
+223
| [[NSString alloc] initWithData:jsonData | ||
| encoding:NSUTF8StringEncoding]; |
There was a problem hiding this comment.
Is it safe to call this with jsonData == nil?
There was a problem hiding this comment.
Good question! I think we are okay as jsonData should be non-nil if error is nil.
Also seems like nil is returned rather than throwing an exception on invalid data for the initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entitlements are returned as JSON, or an empty string if no entitlements are set.
Also added some integration testing to the table.
fleetdm/fleet#25679