Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Revert "Update Windows runner version in hosted_runners.yml (#8618)" #8633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Revert "Update Windows runner version in hosted_runners.yml (#8618)" #8633

merged 1 commit into from
Jun 20, 2025

Conversation

lucasmrod
Copy link
Contributor

@lucasmrod lucasmrod commented Jun 20, 2025 •
edited
Loading

This reverts commit 45411df.

This fixes an issue in osquery 5.18.0 arm64 Windows executable not starting on Window arm64 VMs.

It crashes at startup running any kind of query.

5.18.0 osqueryi.exe:

C:\Users\Lucas>.\osqueryi.exe -S --allow_unsafe --json "SELECT si.uuid, si.hardware_serial, si.hostname, si.computer_name, si.hardware_model, os.platform, os.version as os_version, oi.instance_id, oi.version as osquery_version FROM system_info si, os_version os, osquery_info oi"

C:\Users\Lucas>

Here's the crash report from Event Viewer: Report.wer.txt.
This was also reproduced by @dantecatalfamo.

This PR:

C:\Users\Lucas>.\osqueryi.exe -S --allow_unsafe --json "SELECT si.uuid, si.hardware_serial, si.hostname, si.computer_name, si.hardware_model, os.platform, os.version as os_version, oi.instance_id, oi.version as osquery_version FROM system_info si, os_version os, osquery_info oi"
[
  {"computer_name":"WIN-85PHPP410L4","hardware_model":"QEMU Virtual Machine","hardware_serial":"","hostname":"WIN-85PHPP410L4","instance_id":"85ac589f-2181-4df2-9c3e-db851f42d020","os_version":"10.0.26100","osquery_version":"5.18.0-3-gea580a9f2","platform":"windows","uuid":"4BFBAB91-69AC-4AEE-84FE-82C9B8F16A3E"}
]

@lucasmrod lucasmrod requested a review from a team as a code owner June 20, 2025 14:36
@lucasmrod lucasmrod mentioned this pull request Jun 20, 2025
Closed
zwass
zwass approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go ahead with this to get the release out. But GitHub is about to retire these runners. We will need to figure out what broke.

@lucasmrod lucasmrod merged commit 355b2ad into master Jun 20, 2025
27 checks passed
@lucasmrod lucasmrod deleted the revert-hosted_runners.yml-change branch June 20, 2025 19:01
@lucasmrod lucasmrod mentioned this pull request Jun 20, 2025
Closed
zwass pushed a commit that referenced this pull request Jun 24, 2025
@lucasmrod @zwass
Revert "Update Windows runner version in hosted_runners.yml (#8618)" (#…
d58fe59 
…8633)
@zwass zwass mentioned this pull request Jul 2, 2025
Merged
zwass added a commit that referenced this pull request Jul 10, 2025
@zwass
Revert "Revert "Update Windows runner version in hosted_runners.yml (#…
b890625 
…8618)"" (#8636)

Reverts #8633

Originally we needed to do this to get 5.18.1 working on Windows ARM. Now we are bringing back the newer runners so that Windows unit and integration tests will run successfully.

We will still need to figure out why those Windows builds are crashing on ARM with this runner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwass zwass zwass approved these changes

Assignees

@zwass zwass

Labels

bug build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasmrod @zwass
Morty Proxy This is a proxified and sanitized view of the page, visit original site.