Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

JodhwaniMadhur
Copy link
Contributor

@JodhwaniMadhur JodhwaniMadhur commented Jan 12, 2025

  • Read the CONTRIBUTING.md guide at the root of the repo.
  • Ensure the code is formatted building the format_check target.
    If it is not, then move the committed files to the git staging area,
    build the format target to format them, and then re-commit.
    More information is available on the wiki.
  • Ensure your PR contains a single logical change.
  • Ensure your PR contains tests for the changes you're submitting.
  • Describe your changes with as much detail as you can.
  • Link any issues this PR is related to.
  • Remove the text above.

Resolves #8515

Changed column description for ssid in wifi related tables and added spacing between bytes for ssid value.

@JodhwaniMadhur JodhwaniMadhur requested review from a team as code owners January 12, 2025 14:43
@JodhwaniMadhur
Copy link
Contributor Author

Can someone confirm about the ssid column description? once confirmed, I can then make the changes in the tests

@michael-myers michael-myers changed the title Replacing ssid column description and adding spaces for ssid hexadeci… Update ssid column description, format of its hex string Jan 14, 2025
@michael-myers michael-myers added virtual tables macOS ready for review Pull requests that are ready to be reviewed by a maintainer labels Jan 14, 2025
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-myers What do you think?

@directionless
Copy link
Member

I think that test failure is real

Copy link
Member

@zwass zwass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure needs investigation: #8527 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macOS ready for review Pull requests that are ready to be reviewed by a maintainer virtual tables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mismatch between 'ssid' column definition in schema and actual result

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.