Update make.php #103
Open
Update make.php #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to quote PHP_BINARY's that have spaces e.g. on Windows PHP installations performed by Web Platform Installer.
Contributor
|
I agree with you that it should escape the string in general but in the interim couldn't you instead of: |
Author
|
Yep guess you could use the 8.3 filename and hard code it into the file. This would just alleviate that process. Was just thinking from a continual improvement perspective and to save others troubleshooting the "'C:\Program' is not recognized as an internal or external command, operable program or batch file." error. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to quote PHP_BINARY's that have spaces e.g. on Windows PHP installations performed by Web Platform Installer.