-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[POI] Added few POIs #10494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[POI] Added few POIs #10494
Conversation
Please, rebase on the latest master. |
Rebased. |
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Rendered icon similar to shop=music - Gave it lower priority than shop=music - Not sure about icon , suggest if better options - Added only en string ( should i autotranslate rest with DEEPL ) Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Used OSM carto's icon , its similar to other sport icons in OM - priority similar to leisure=sports_center - amenity=dancing_school seems to be already replaced with leisure=dance Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Used OSM carto's icon , its similar to outdoor icons in OM , same color as red icons in OM (eg : emergency-phone-m.svg) - priority & icon rendering similar to amenity=bbq Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Can add a new heart icon , but not sure as this is kind of niche , for now used same icon as amenity=brothel, ( theres also shop=erotic that can be modified and used) - priority & icon rendering similar to amenity=brothel Signed-off-by: hemanggs <hemangmanhas@gmail.com>
Rebased after #10493 |
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
Colleagues, do we need guard_rail? What is the possible use case here? |
Some use cases are listed in the issue (people with disabilities who can't jump over the rail to cross the road), meaning walking routing can avoid such places in the future. Another possible use case: it is safer to have a roadside walk without any rails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these icons free-licensed by boxicons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem to be free-licensed and open source , although im no license expert can someone verify.
ref: https://docs.boxicons.com/license/free
the one used : https://boxicons.com/icons/play-circle
Firepit : OSM icon used
Dance : OSM icon used
love_hotel : reused amenity=brothel
Ref :
#9792
#1917
Studio icon used : https://boxicons.com/?query=play
Alternate icon ideas : https://thenounproject.com/search/icons/?q=studio
Alternate love hotel icon ideas : https://boxicons.com/?query=heart