Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[POI] Added few POIs #10494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
Loading
from
Open

Conversation

hemanggs
Copy link
Contributor

Ref :
#9792
#1917

Image 1 Image 2
image barrier=guard_rail

Studio icon used : https://boxicons.com/?query=play
Alternate icon ideas : https://thenounproject.com/search/icons/?q=studio

amenity=studio




Alternate love hotel icon ideas : https://boxicons.com/?query=heart

amenity=love_hotel

@hemanggs hemanggs requested review from a team as code owners March 28, 2025 05:32
@hemanggs hemanggs changed the title Added few POIs [POI] Added few POIs Mar 28, 2025
data/mapcss-mapping.csv Outdated Show resolved Hide resolved
@vng
Copy link
Member

vng commented May 16, 2025

Please, rebase on the latest master.

@hemanggs
Copy link
Contributor Author

hemanggs commented May 16, 2025

Rebased.

3party/gflags Outdated Show resolved Hide resolved
hemanggs added 5 commits May 17, 2025 01:08
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Rendered icon similar to shop=music
- Gave it lower priority than shop=music
- Not sure about icon , suggest if better options
- Added only en string ( should i autotranslate rest with DEEPL )
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Used OSM carto's icon , its similar to other sport icons in OM
- priority similar to leisure=sports_center
- amenity=dancing_school  seems to be  already replaced with leisure=dance

Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Used OSM carto's icon , its similar to outdoor icons in OM
, same color as red icons in OM (eg : emergency-phone-m.svg)

-  priority & icon rendering similar to amenity=bbq

Signed-off-by: hemanggs <hemangmanhas@gmail.com>
- Can add a new heart icon , but not sure as this is kind of niche , for now used same icon as amenity=brothel, ( theres also shop=erotic that can be modified and used)

-  priority & icon rendering similar to amenity=brothel

Signed-off-by: hemanggs <hemangmanhas@gmail.com>
@hemanggs
Copy link
Contributor Author

Rebased after #10493

hemanggs added 3 commits May 17, 2025 01:31
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
Signed-off-by: hemanggs <hemangmanhas@gmail.com>
@vng
Copy link
Member

vng commented May 16, 2025

Colleagues, do we need guard_rail? What is the possible use case here?

@biodranik
Copy link
Member

Colleagues, do we need guard_rail? What is the possible use case here?

Some use cases are listed in the issue (people with disabilities who can't jump over the rail to cross the road), meaning walking routing can avoid such places in the future.

Another possible use case: it is safer to have a roadside walk without any rails.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these icons free-licensed by boxicons?

Copy link
Contributor Author

@hemanggs hemanggs May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does seem to be free-licensed and open source , although im no license expert can someone verify.

ref: https://docs.boxicons.com/license/free
the one used : https://boxicons.com/icons/play-circle

Firepit : OSM icon used
Dance : OSM icon used
love_hotel : reused amenity=brothel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.