Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Remove merge conflicts from src/testlink/testlinkapi.py#8

Closed
adamsar wants to merge 2 commits intoorenault:masterorenault/TestLink-API-Python-client:masterfrom
adamsar:masteradamsar/TestLink-API-Python-client:masterCopy head branch name to clipboard
Closed

Remove merge conflicts from src/testlink/testlinkapi.py#8
adamsar wants to merge 2 commits intoorenault:masterorenault/TestLink-API-Python-client:masterfrom
adamsar:masteradamsar/TestLink-API-Python-client:masterCopy head branch name to clipboard

Conversation

@adamsar
Copy link

@adamsar adamsar commented Oct 7, 2013

Fixed the merge conflict on this. The test cases seem to be written for a specific project however.

@adamsar
Copy link
Author

adamsar commented Oct 7, 2013

Also added external id to getTestCaseById. I think I may have violated your styleguide though as on second inspection it looks like you name your parameters by how they are reflected in the actual TestLinkAPI.

@lczub
Copy link
Contributor

lczub commented Oct 13, 2013

Hello Andrew,

I currently starts a little refactoring for the v0.4.5 to implement a more flexible handling of optional arguments.
(see lczub#7 and https://github.com/lczub/TestLink-API-Python-client/tree/generic-api)

With the, you would be able to call getTestCase() in two versions:

tlapiclient.getTestCase(testcaseid=4711)

or

tlapiclient.getTestCase(testcaseexternalid='GPROAPI-4711')

Would this be an acceptable solution for you?

@adamsar
Copy link
Author

adamsar commented Oct 14, 2013

Hello Iczub,

That sounds like a great solution. I am concurrently working on another python implementation of the Testlink API, albeit a more "REST"-y abstraction. I think our two projects will offer developers a good selection when working with TestLink.

My project is started at https://github.com/adamsar/testlink-python-api/tree/master/testlink

The basic usage of mine would be something like:

for case in self.api.projects.get("project name").plans.get("plan_id").cases.cursor:
  case.report(platform_id='id', status=statuses.SUCCESS, notes='This is automated')

Anyway, thanks for working on this Python wrapper! I've used it in a recent project and it was quite helpful.

@lczub
Copy link
Contributor

lczub commented Oct 20, 2013

Hello Andrew (and other interested parties),
I published today a pre release v0.4.5-Alpha for the generic api implementation lczub#7.
Is it possible, that you make some tests with it, if this refactoring fits your requirements for the optional argument handling?
Feedback are welcome under lczub/TestLink-API-Python-client/issues

Greetings Luiko

orenault pushed a commit that referenced this pull request May 28, 2017
module testlinkargs is used as a 'singleton' to register the supported
TestLink API methods and there (positional and optional) arguments
- replace testlinkapigeneric.positionalArgNamesDefault

new decorator factory decoMakerApiCallWithArgs() 
- realize, that the decorator decoApiCallWithArgs could register API
methods and there arguments with new function
testlinkargs.registerMethod()
orenault pushed a commit that referenced this pull request May 28, 2017
separation makes module testlinkapigeneric more readable
orenault pushed a commit that referenced this pull request May 28, 2017
@orenault orenault closed this in eeb2081 May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.