Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Support stable EA builds#83

Merged
sormuras merged 5 commits intomainoracle-actions/setup-java:mainfrom
issues/82-support-ea-stableoracle-actions/setup-java:issues/82-support-ea-stableCopy head branch name to clipboard
Jun 14, 2024
Merged

Support stable EA builds#83
sormuras merged 5 commits intomainoracle-actions/setup-java:mainfrom
issues/82-support-ea-stableoracle-actions/setup-java:issues/82-support-ea-stableCopy head branch name to clipboard

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Jun 12, 2024

Please review this change that adds support for a ea,stable,... alias key. Usage in workflow files would look like this:

      - name: 'Set up stable EA JDK'
        uses: oracle-actions/setup-java@v1
        with:
          website: jdk.java.net
          release: ea
          version: stable

Closes #82

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 12, 2024
@sormuras sormuras marked this pull request as ready for review June 14, 2024 07:25
@sormuras sormuras requested a review from delabassee June 14, 2024 07:25
delabassee
delabassee approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@delabassee delabassee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sormuras sormuras merged commit fde7666 into main Jun 14, 2024
@sormuras sormuras deleted the issues/82-support-ea-stable branch June 14, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delabassee delabassee delabassee approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EA tag moves [too early] during ramp down phase ... so EA builds no longer validate the next JDK release?

2 participants

@sormuras @delabassee
Morty Proxy This is a proxified and sanitized view of the page, visit original site.