Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Consolidate string handling in cxoTransform_toPython #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Consolidate string handling in cxoTransform_toPython #419

merged 1 commit into from
Apr 17, 2020

Conversation

alexhenrie
Copy link
Contributor

There's no need to have the same code twice in this function.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
@anthony-tuininga
Copy link
Member

Thanks for noticing that the code is duplicated now that only Python 3 support is needed. We can only accept your contribution, however, if you sign the OCA. @cjbj can provide additional details if needed.

@cjbj
Copy link
Member

cjbj commented Apr 17, 2020

@alexhenrie The OCA is here. (Did this not get shown when you created the PR or do we need to tweak a template?)

@alexhenrie
Copy link
Contributor Author

I have already signed the OCA. Is there another form I need to submit?

@cjbj
Copy link
Member

cjbj commented Apr 17, 2020

Hi @alexhenrie thanks for doing that (even for this small change). Has your OCA been accepted? I don't immediately see your name on https://www.oracle.com/technetwork/community/oca-486395.html

Also, can you do the PR sign off git commit --signoff mention in the earlier link?

@alexhenrie
Copy link
Contributor Author

It's in the H section, under "Alex Henrie", and I did include the Signed-off-by line in my commit message.

@alexhenrie
Copy link
Contributor Author

I think maybe you missed it before because my OCA was originally for OpenJDK, but the page says that I don't need to sign a new one to contribute to other Oracle projects.

@cjbj
Copy link
Member

cjbj commented Apr 17, 2020

@alexhenrie all is good. Thanks!

@anthony-tuininga anthony-tuininga merged commit 5ad2408 into oracle:master Apr 17, 2020
@anthony-tuininga
Copy link
Member

Thanks!

@alexhenrie
Copy link
Contributor Author

Thank you!

@alexhenrie alexhenrie deleted the strings branch April 17, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.