-
|
I have defined a custom resource @ControllerConfiguration(namespaces = Constants.WATCH_CURRENT_NAMESPACE)
public class AppController implements Reconciler<App>, EventSourceInitializer<App> {
private final Workflow<App> workflow;
public AppController(OperatorProperties properties) {
this.workflow = new WorkflowBuilder<>()
.addDependentResource(new AppServiceAccount(properties))
.addDependentResource(new AppRole(properties))
.addDependentResource(new AppRoleBinding(properties))
.addDependentResource(new AppDeployment(properties))
.addDependentResource(new AppConfigMap(properties))
.addDependentResource(new AppService(properties))
.addDependentResource(new AppIngress(properties))
.build();
}
@Override
public Map<String, EventSource> prepareEventSources(EventSourceContext<App> context) {
return EventSourceInitializer.eventSourcesFromWorkflow(context, workflow);
}
@Override
public UpdateControl<App> reconcile(App app, Context<App> context) {
workflow.reconcile(app, context);
return UpdateControl.noUpdate()
}
}When I deploy a new Is this some sort of expected timing issue, or what am I missing to avoid those exceptions? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments · 3 replies
-
|
It's difficult to tell just from this context but it might indeed be a timing issue, where some of your dependents might require the RoleBinding to be created before they can be reconciled. In that situation, you can create your workflow in such a way that the dependents that depend on the RoleBinding being present won't be reconciled until the RoleBinding exists either via a "depends on" relationship or a reconcile precondition on the dependents that require the RoleBinding to be reconciled. See https://javaoperatorsdk.io/docs/workflows/#elements-of-workflow for more details. |
Beta Was this translation helpful? Give feedback.
-
|
Creating the workflow with dependencies seems to have fixed the issue, thanks! Workflow<App> appWorkflow(OperatorProperties properties) {
var serviceAccount = new AppServiceAccount(properties);
var role = new AppRole(properties);
var roleBinding = new AppRoleBinding(properties);
var deployment = new AppDeployment(properties);
var configMap = new AppConfigMap(properties);
var service = new AppService(properties);
var ingress = new AppIngress(properties);
// @formatter:off
return new WorkflowBuilder<App>()
.addDependentResource(serviceAccount)
.addDependentResource(role)
.addDependentResource(roleBinding)
.dependsOn(role, serviceAccount)
.addDependentResource(configMap)
.addDependentResource(deployment)
.dependsOn(serviceAccount)
.addDependentResource(service)
.dependsOn(deployment)
.addDependentResource(ingress)
.dependsOn(service)
.withReconcilePrecondition(new AppIngressCondition())
.build();
// @formatter:on
} |
Beta Was this translation helpful? Give feedback.
-
|
@heruan what version of the framework are you using? This should not happen with newer version which use SSA. If you could create a reproducer we can take a look. |
Beta Was this translation helpful? Give feedback.
-
|
I'm using 4.9.5 that comes with the latest JOSDK Spring Boot starter 5.6.0. What is SSA? Explicitly setting dependencies in the workflow seems to have fixed the issue. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, that it should be ok, there are other reasons where we saw this failing. Ordering is one of them. SSA is Server Side Apply. |
Beta Was this translation helpful? Give feedback.
It's difficult to tell just from this context but it might indeed be a timing issue, where some of your dependents might require the RoleBinding to be created before they can be reconciled. In that situation, you can create your workflow in such a way that the dependents that depend on the RoleBinding being present won't be reconciled until the RoleBinding exists either via a "depends on" relationship or a reconcile precondition on the dependents that require the RoleBinding to be reconciled. See https://javaoperatorsdk.io/docs/workflows/#elements-of-workflow for more details.