Update the Python 3 PR #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flaker
commented
Jun 19, 2017
- Use PR https://github.com/openx/OX3-Python-API-Client/pull/22/file…
- Fix tests.
…to add Python 3 support. - Fix tests.
Contributor
Author
|
I could not override the mock for test_delete. All the tests are sharing the same mocks, client, etc which makes things a bit more difficult. Refactoring them allowing each test to change the mocks with no side effects would be nice. Also I removed some tests that were not real tests (just a 'pass') This PR was tested under Python 2.7.13 and 3.6.1 with the following list of pkgs: $ pip freeze
certifi==2017.4.17
chardet==3.0.4
idna==2.5
mock==2.0.0
oauthlib==2.0.2
pbr==3.0.1
requests==2.18.1
requests-oauthlib==0.8.0
six==1.10.0
urllib3==1.21.1 |
Contributor
Author
|
Removed the shared state between tests. |
added 3 commits
June 19, 2017 11:09
…s ran consistently only for Python 2.
- Updated instructions to run tests - Updated versioning information
Contributor
|
Looks good now. |
This was referenced Jun 19, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.