Conversation
| ///The UUId of tenant who owns the scurity group | ||
| /// </summary> | ||
| [JsonProperty("tenant_id")] | ||
| public string TenantId; |
There was a problem hiding this comment.
TenantId should be removed.
In general, admin-only properties should not be exposed in the main namespaces. The idea being that if a user picks up the SDK, they only see functionality and data that they are able to work with. If an operator wants to add admin functionality to the SDK, it is implemented in an XXX.Operator namespace, so that users don't see it unless they explicitly import it. 😄
|
This is great! I left some comments about the SDK guidelines that I've been using to keep each service consistent and hopefully a better user experience. If you would update the PR with those changes, this is ready to merge and then ship with v1.7.0 which is currently in beta but will be going out soon! |
|
I am closing this PR and will complete the work started here in #619. Thanks! |
|
@JiangZehua Thank you for contributing! Your work is now available in v1.7.0. |
No description provided.