Object Storage: Added option to specify headers for copy operations #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the API supports copying one object to another location within an OpenStack instance. For this purpose, the PUT operation is used and the source object location is specified using the
X-Copy-Fromheader (https://docs.openstack.org/api-ref/object-store/?expanded=copy-object-detail#copy-object).In addition, OpenStack allows specifying different options using headers, e.g.
X-Delete-Aftercan be used to set a TTL for an object. For similar operations (like PUT), these headers can be set using the ObjectPutOptions but there is currently no way to do this for the copy operation.This pr introduces an optional argument of the type ObjectCopyOptions for the copy() option the same way it is implemented for the other operations.
Furthermore, I've added methods for specifying the TTL without explicitly setting the headers.
In addition, I've updated the version of the shade plugin as this significantly speeds up the building process.
I don't think unit tests are applicable here but I have tested my changes manually against OVH OpenStack.