vms_term_sock: check listen() return in CreateSocketPair #28910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
Sashan
requested changes
Oct 16, 2025
| ** Setup a listen for the socket | ||
| */ | ||
| listen (SockDesc1, 5); | ||
| if (listen (SockDesc1, 5) < 0) { |
There was a problem hiding this comment.
to be honest I would expect listen() to fail. So I'm on edge with this. but let's see what @levitte thinks here.
|
|
||
| if (mbuf == NULL || fbio == NULL) { | ||
| BIO_printf(bio_err /* may be NULL */, "%s: out of memory", prog); | ||
| if (bio_err) |
There was a problem hiding this comment.
I think we should either drop the change and leave the code as is, because bio_err == NULL is handled by underlying BIO_write() or we can fold bio_err == NULL into BIO_printf() itself. This should make cost of failure cheaper in terms of CPU cycles. Currently we do all complex buffer handling related to format string processing just to discover BIO_write() fails because of bio being NULL.
so this is the change I would suggest here, but let's wait what other people here think. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.