Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add access_by_lua(_block/_file) and access_by_lua_no_postpone #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arcivanov wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

Add access_by_lua(_block/_file) and access_by_lua_no_postpone #217

arcivanov wants to merge 1 commit into from

Conversation

@arcivanov
Copy link

@arcivanov arcivanov commented Nov 9, 2020

Some rudimentary tests

@arcivanov arcivanov force-pushed the access_by_lua branch 2 times, most recently from 42a195d to 7b9c916 Compare November 9, 2020 09:15
deba12
deba12 reviewed Nov 9, 2020
View reviewed changes
src/ngx_stream_lua_accessby.c Outdated Show resolved Hide resolved
@arcivanov
Copy link
Author

arcivanov commented Nov 10, 2020

@agentzh @xiaocang @tangsty please review and merge.
The failures appear in SSL and unrelated to the changes.

@arcivanov
Copy link
Author

arcivanov commented Nov 18, 2020

@agentzh @xiaocang @tangsty bump?

@arcivanov
Copy link
Author

arcivanov commented Nov 28, 2020

@spacewander @xiaocang @tangsty @agentzh bump

1 similar comment
@arcivanov
Copy link
Author

arcivanov commented Dec 6, 2020

@spacewander @xiaocang @tangsty @agentzh bump

@edevil
Copy link

edevil commented Dec 6, 2020

This would also be useful for me since I want to resolve a name to be used in balancer_by_lua_block.

@arcivanov
Copy link
Author

arcivanov commented Dec 8, 2020

@spacewander @xiaocang @tangsty @agentzh bump

1 similar comment
@arcivanov
Copy link
Author

arcivanov commented Feb 12, 2021

@spacewander @xiaocang @tangsty @agentzh bump

@xiaocang
Copy link
Contributor

xiaocang commented Jul 16, 2021

@arcivanov Got it, I'll look into it.

spacewander
spacewander reviewed Jul 16, 2021
View reviewed changes
t/089-phase.t
TODO
--- SKIP
--- stream_server_config
access_by_lua_block {
Copy link
Member

@spacewander spacewander Jul 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that using both preread and access phases?
Does the access phase have the limitation below in the preread phase?

However, keep in mind that calling the receive() method of the request socket will consume the data from the buffer and such consumed data will not be seen by handlers further down the chain.

@arcivanov
Add access_by_lua(_block/_file) and access_by_lua_no_postpone
0e2e7b3 
Some rudimentary tests

Requested cleanup of `#if 1`

Try fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander left review comments

+1 more reviewer

@deba12 deba12 deba12 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arcivanov @edevil @xiaocang @deba12 @spacewander
Morty Proxy This is a proxified and sanitized view of the page, visit original site.