Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@LuckyMD
Copy link
Collaborator

@LuckyMD LuckyMD commented Jan 10, 2023

Just changed the folder name and README title for the task. Anything else that would need to be changed @scottgigante-immunai ? Website should pull directly from this, no?

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 94.93% // Head: 94.98% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (3066a43) compared to base (5f8fd17).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   94.93%   94.98%   +0.04%     
==========================================
  Files         157      157              
  Lines        4288     4288              
  Branches      227      227              
==========================================
+ Hits         4071     4073       +2     
+ Misses        142      141       -1     
+ Partials       75       74       -1     
Flag Coverage Δ
unittests 94.98% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openproblems/tasks/matching_modalities/api.py 100.00% <ø> (ø)
...lems/tasks/matching_modalities/datasets/citeseq.py 100.00% <ø> (ø)
...blems/tasks/matching_modalities/datasets/scicar.py 100.00% <ø> (ø)
...lems/tasks/matching_modalities/methods/baseline.py 100.00% <ø> (ø)
.../matching_modalities/methods/harmonic_alignment.py 90.24% <ø> (ø)
...nproblems/tasks/matching_modalities/methods/mnn.py 100.00% <ø> (ø)
...ms/tasks/matching_modalities/methods/procrustes.py 100.00% <ø> (ø)
...blems/tasks/matching_modalities/metrics/knn_auc.py 100.00% <ø> (ø)
...nproblems/tasks/matching_modalities/metrics/mse.py 82.35% <ø> (ø)
...l_cell_communication/_common/metrics/odds_ratio.py 100.00% <0.00%> (+7.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottgigante-immunai
Copy link
Collaborator

The diff in this PR doesn't look right... you should be renaming the entire task folder and everything in it, instead I just see a single new markdown file.

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jan 10, 2023

hmm, it looks like the stuff wasn't added when i renamed the folder.

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jan 10, 2023

should be fixed now

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jan 10, 2023

there, now it looks better ^^.

@scottgigante-immunai
Copy link
Collaborator

All tests failing (: Fixed with 8c8c769

@scottgigante-immunai
Copy link
Collaborator

Website should pull directly from this, no?

We will probably need to rename the image file corresponding with this task on the website, but that's a TODO for the website PR that will result from this change.

Also, we probably shouldn't merge this until we're ready to rerun the benchmark, as the resulting content PR will break due to out of date results files.

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Jan 11, 2023

Ah, right... thx for catching the import change. Makes sense to keep this here until the benchmark rerun.

@scottgigante-immunai scottgigante-immunai merged commit d77a949 into main Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Current build status

@rcannood rcannood deleted the rename_mulitmodal_integration branch September 4, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.