-
Notifications
You must be signed in to change notification settings - Fork 86
change multimodal data integration task name to matching modalities #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 94.93% // Head: 94.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 94.93% 94.98% +0.04%
==========================================
Files 157 157
Lines 4288 4288
Branches 227 227
==========================================
+ Hits 4071 4073 +2
+ Misses 142 141 -1
+ Partials 75 74 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The diff in this PR doesn't look right... you should be renaming the entire task folder and everything in it, instead I just see a single new markdown file. |
|
hmm, it looks like the stuff wasn't added when i renamed the folder. |
|
should be fixed now |
|
there, now it looks better ^^. |
|
All tests failing (: Fixed with 8c8c769 |
We will probably need to rename the image file corresponding with this task on the website, but that's a TODO for the website PR that will result from this change. Also, we probably shouldn't merge this until we're ready to rerun the benchmark, as the resulting content PR will break due to out of date results files. |
|
Ah, right... thx for catching the import change. Makes sense to keep this here until the benchmark rerun. |
Just changed the folder name and README title for the task. Anything else that would need to be changed @scottgigante-immunai ? Website should pull directly from this, no?