Pre-normalize dimensionality reduction datasets #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazappi
requested changes
Jan 9, 2023
Member
lazappi
left a comment
There was a problem hiding this comment.
Looks pretty good to me. Comments are mostly about documentation except for the one about resetting the normalisation.
openproblems/tasks/dimensionality_reduction/datasets/mouse_hspc_nestorowa2016.py
Show resolved
Hide resolved
10 tasks
Collaborator
Author
|
@lazappi can you please re-review to unblock? Thanks! |
lazappi
approved these changes
Jan 10, 2023
Codecov ReportBase: 94.78% // Head: 94.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 94.78% 94.86% +0.07%
==========================================
Files 155 154 -1
Lines 4163 4226 +63
Branches 215 220 +5
==========================================
+ Hits 3946 4009 +63
Misses 142 142
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #756
Passing tests at https://tower.nf/orgs/openproblems-bio/workspaces/openproblems-bio/watch/1hRAN5DgnkDqOK