Update EMUC in SCC calculation#7
Open
felixschaumann wants to merge 3 commits intoopenmodels:masteropenmodels/META:masterfrom
Open
Update EMUC in SCC calculation#7felixschaumann wants to merge 3 commits intoopenmodels:masteropenmodels/META:masterfrom
felixschaumann wants to merge 3 commits intoopenmodels:masteropenmodels/META:masterfrom
Conversation
Author
|
Related to this, I just came across this line in montecarlo.jl draws.Consumption_EMUC = rand(TriangularDist(0.5, 2, 1.5), trials)where the emuc distribution is centered around 1.5 — I guess it should be 1.05 here as well? Cheers! |
Update to follow META developments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading META and calculating SCCs,
changing the
EMUCvalues leads to huge changes. This stems from the fact thatemucis changed within thecalculate_sccfunction, but not theEMUCparameter ofmodelitself.This pull request hence proposes to update the
modelEMUCparameter at the beginning of each SCC calculation such that the two values are always identical and this inconsistency can never occur.Alternatively, one could also warn users in the README and recommend to run
before every SCC calculation with an emuc value of
new_emucwhich is different from the default model value.Note: This pull request contains the other pull request #5 which is only there to make the compile properly but does not change anything functionally.