Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update EMUC in SCC calculation#7

Open
felixschaumann wants to merge 3 commits intoopenmodels:masteropenmodels/META:masterfrom
felixschaumann:update_emuc_sccfelixschaumann/META:update_emuc_sccCopy head branch name to clipboard
Open

Update EMUC in SCC calculation#7
felixschaumann wants to merge 3 commits intoopenmodels:masteropenmodels/META:masterfrom
felixschaumann:update_emuc_sccfelixschaumann/META:update_emuc_sccCopy head branch name to clipboard

Conversation

@felixschaumann
Copy link
Copy Markdown

When loading META and calculating SCCs,

model = base_model(rcp="RCP4.5", ssp="SSP2", tdamage="pointestimate", slrdamage="mode");
run(model)
calculate_scc(model, 2020, 10., 1.05) # --> 95$
calculate_scc(model, 2020, 10., 1.5) # --> 6668$

changing the EMUC values leads to huge changes. This stems from the fact that emuc is changed within the calculate_scc function, but not the EMUC parameter of model itself.

This pull request hence proposes to update the model EMUC parameter at the beginning of each SCC calculation such that the two values are always identical and this inconsistency can never occur.

Alternatively, one could also warn users in the README and recommend to run

update_param!(model, :Utility_EMUC, new_emuc)

before every SCC calculation with an emuc value of new_emuc which is different from the default model value.


Note: This pull request contains the other pull request #5 which is only there to make the compile properly but does not change anything functionally.

@felixschaumann
Copy link
Copy Markdown
Author

Related to this, I just came across this line in montecarlo.jl

draws.Consumption_EMUC = rand(TriangularDist(0.5, 2, 1.5), trials)

where the emuc distribution is centered around 1.5 — I guess it should be 1.05 here as well?

Cheers!

Update to follow META developments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.