Cache dataset features and qualities as pickle#979
Conversation
PGijsbers
requested changes
Oct 29, 2020
Collaborator
PGijsbers
left a comment
There was a problem hiding this comment.
Some minor changes, but also the unit tests fail so need to be fixed.
PGijsbers
approved these changes
Oct 29, 2020
Collaborator
|
Can merge if CI passes (at least some of them, to make sure the merge conflict was resolved correctly 馃槗 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
#908
What does this PR implement/fix? Explain your changes.
This PR changes the loading behavior of loading dataset qualities and dataset features. They are now loaded inside the
OpenMLDatasetclass. Furthermore, when loaded first, the parsed XML is saved as a pickle, which is loaded upon future invocations.How should this PR be tested?
New unittests in test/test_datasets/test_dataset.py
Any other comments?
This PR improves the loading speed of datasets. Obviously, the files which are cached as pickle are only large if the datasets have a lot of features. The most drastic improvement I could observe was for the dataset dorothea, where the loading time reduced from ~13s to ~0.2s.