Codecov Report

Merging #903 into develop will decrease coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop     #903     +/-   ##
==========================================
- Coverage    88.13%   88.03%   -0.1%     
==========================================
  Files           37       37             
  Lines         4364     4364             
==========================================
- Hits          3846     3842      -4     
- Misses         518      522      +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d429c...0f29caf. Read the comment docs.

Edit: My bad! Looks like did not see the last commit you made to this PR. Seems like you figured it out. You can make flake8 ignore the unused import by adding an in-line comment # noqa: F401. I think the other unit test failure is unrelated to the changes in this PR.

old comment:

The issue might have been too vague. The desired behavior is to be able to do this:

import openml
print(openml.__version__)  # 0.11.0dev

but not this:

from openml import *
__version__

The latter currently works fine (__version__ evaluates to the version str), but it should instead raise NameError: name '__version__' is not defined.

Using openml.__version__ is the normal way to check a package version. It should remain functional (and is also used in unit tests).

From my understanding this means the only change required would be to remove this line. But you would need to verify that.

Looks good to me! Thank you for your contribution 🎉

Thanks a lot for the review and suggestions!