Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Do not populate server base URL on startup#873

Merged
PGijsbers merged 3 commits intodevelopopenml/openml-python:developfrom
fix_print_entitiesopenml/openml-python:fix_print_entitiesCopy head branch name to clipboard
Nov 8, 2019
Merged

Do not populate server base URL on startup#873
PGijsbers merged 3 commits intodevelopopenml/openml-python:developfrom
fix_print_entitiesopenml/openml-python:fix_print_entitiesCopy head branch name to clipboard

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Nov 7, 2019

As this will result in wrong outputs if the server is changed during the execution of a program

@mfeurer mfeurer requested a review from PGijsbers November 8, 2019 12:27
@mfeurer mfeurer marked this pull request as ready for review November 8, 2019 12:27
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@PGijsbers PGijsbers merged commit fb1c1d9 into develop Nov 8, 2019
@PGijsbers PGijsbers deleted the fix_print_entities branch November 8, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.