pass skipna=False explicitly#766
Merged
mfeurer merged 3 commits intoopenml:developopenml/openml-python:developfrom Sep 4, 2019
Merged
pass skipna=False explicitly#766mfeurer merged 3 commits intoopenml:developopenml/openml-python:developfrom
mfeurer merged 3 commits intoopenml:developopenml/openml-python:developfrom
Conversation
[WIP] New release
Release version 0.9
pass skipna=False explicitly to avoids pandas FutureWarning: " A future version of pandas will default to `skipna=True`. To silence this warning, pass `skipna=True|False` explicitly."
Codecov Report
@@ Coverage Diff @@
## develop #766 +/- ##
==========================================
- Coverage 87.67% 87.57% -0.1%
==========================================
Files 36 36
Lines 4072 4072
==========================================
- Hits 3570 3566 -4
- Misses 502 506 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/fix? Explain your changes.
Pass skipna=False explicitly when calling pd.api.types.infer_dtype to avoid behavioral change and pandas FutureWarning: " A future version of pandas will default to
skipna=True. To silence this warning, passskipna=True|Falseexplicitly."