Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update documentation#740

Merged
mfeurer merged 3 commits intodevelopopenml/openml-python:developfrom
update_docsopenml/openml-python:update_docsCopy head branch name to clipboard
Jul 26, 2019
Merged

Update documentation#740
mfeurer merged 3 commits intodevelopopenml/openml-python:developfrom
update_docsopenml/openml-python:update_docsCopy head branch name to clipboard

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Jul 19, 2019

This pull request does

  • dynamically generate the copyright year
  • replaces pprint by print
  • updates one example to use a more common task on the test server
  • fix a few docstring syntax issues
  • introduce stricter checks for correct XML files (I had old files on my machine, and the error message were not helpful).

Neeratyoy
Neeratyoy reviewed Jul 22, 2019
View reviewed changes
doc/index.rst Show resolved Hide resolved
@Neeratyoy
Copy link
Contributor

Neeratyoy commented Jul 22, 2019

Looks like a certain test__get_cached_dataset unit test is failing since the new nominal values check in openml/datasets/data_feature.py is raising an error.

@mfeurer mfeurer marked this pull request as ready for review July 23, 2019 08:37
@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #740 into develop will decrease coverage by 0.23%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #740      +/-   ##
===========================================
- Coverage    87.99%   87.76%   -0.24%     
===========================================
  Files           36       36              
  Lines         4081     4004      -77     
===========================================
- Hits          3591     3514      -77     
  Misses         490      490
Impacted Files Coverage Δ
openml/study/functions.py 88.23% <ø> (ø) ⬆️
openml/datasets/dataset.py 84.07% <ø> (ø) ⬆️
openml/setups/setup.py 42.3% <ø> (ø) ⬆️
openml/testing.py 96.21% <0%> (-0.18%) ⬇️
openml/tasks/functions.py 84.93% <100%> (ø) ⬆️
openml/datasets/data_feature.py 68% <57.14%> (-2%) ⬇️
openml/extensions/sklearn/extension.py 90.62% <0%> (-0.59%) ⬇️
openml/datasets/functions.py 95.16% <0%> (-0.33%) ⬇️
openml/flows/functions.py 87.78% <0%> (-0.19%) ⬇️
openml/flows/flow.py 93.8% <0%> (-0.06%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c71d1d...3348482. Read the comment docs.

@mfeurer mfeurer merged commit b59cc46 into develop Jul 26, 2019
@mfeurer mfeurer deleted the update_docs branch November 12, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neeratyoy Neeratyoy Neeratyoy approved these changes

@PGijsbers PGijsbers Awaiting requested review from PGijsbers

@joaquinvanschoren joaquinvanschoren Awaiting requested review from joaquinvanschoren

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfeurer @Neeratyoy @codecov-io
Morty Proxy This is a proxified and sanitized view of the page, visit original site.