Fix dataset parsing for categories#676
Merged
janvanrijn merged 2 commits intodevelopopenml/openml-python:developfrom Apr 16, 2019
Merged
Fix dataset parsing for categories#676janvanrijn merged 2 commits intodevelopopenml/openml-python:developfrom
janvanrijn merged 2 commits intodevelopopenml/openml-python:developfrom
Conversation
janvanrijn
reviewed
Apr 16, 2019
Member
janvanrijn
left a comment
There was a problem hiding this comment.
Looks good to me, the unit test drives the point home.
Can you please add a single line comment to specify why this is a 2-liner, so we know in future? Can be merged afterwards.
Codecov Report
@@ Coverage Diff @@
## develop #676 +/- ##
===========================================
+ Coverage 90.89% 90.95% +0.05%
===========================================
Files 36 36
Lines 3558 3736 +178
===========================================
+ Hits 3234 3398 +164
- Misses 324 338 +14
Continue to review full report at Codecov.
|
Member
|
I can attest that all tests are green btw |
Collaborator
Author
|
Okay, I did so. |
janvanrijn
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR #548 changed the behavior of retrieving the categories of a categorical variable by inducing it from the data. In case the data does not contain a category, we loose information about its potential existence. This PR uses the category information provided by the arff file to determine all legal categories of a categorical variable.