Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fixes issue #565 and removes future / deprecation warnings#566

Merged
mfeurer merged 4 commits intodevelopopenml/openml-python:developfrom
fix_#565openml/openml-python:fix_#565Copy head branch name to clipboard
Oct 12, 2018
Merged

fixes issue #565 and removes future / deprecation warnings#566
mfeurer merged 4 commits intodevelopopenml/openml-python:developfrom
fix_#565openml/openml-python:fix_#565Copy head branch name to clipboard

Conversation

@janvanrijn
Copy link
Member

Fixes #565

@mfeurer
Copy link
Collaborator

mfeurer commented Oct 8, 2018

It seems like the tests are failing with older scikit-learn versions.

@codecov-io
Copy link

codecov-io commented Oct 9, 2018

Codecov Report

Merging #566 into develop will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #566      +/-   ##
===========================================
- Coverage    89.91%   89.88%   -0.03%     
===========================================
  Files           32       32              
  Lines         2915     2917       +2     
===========================================
+ Hits          2621     2622       +1     
- Misses         294      295       +1
Impacted Files Coverage 螖
openml/setups/functions.py 94.4% <60%> (-0.73%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ba94609...fef6c89. Read the comment docs.

@janvanrijn
Copy link
Member Author

I honestly have no clue why the code crashed before. According to my analysis, this should not have happened. I made some changes to the if/else structure of the setup_exists fn, as I had the impression that this was not according to the way it should be. These should have had no influence on the code crashing or not. @mfeurer what do you think?

@mfeurer mfeurer merged commit 779fb82 into develop Oct 12, 2018
@mfeurer mfeurer deleted the fix_#565 branch October 12, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.