Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

#563 Fixing run print bug with blank flow_name#552

Merged
mfeurer merged 1 commit intoopenml:developopenml/openml-python:developfrom
ledell:add_#536ledell/openml-python:add_#536Copy head branch name to clipboard
Sep 24, 2018
Merged

#563 Fixing run print bug with blank flow_name#552
mfeurer merged 1 commit intoopenml:developopenml/openml-python:developfrom
ledell:add_#536ledell/openml-python:add_#536Copy head branch name to clipboard

Conversation

@ledell
Copy link
Contributor

@ledell ledell commented Sep 22, 2018

Reference Issue

Fixes #536

What does this PR implement/fix? Explain your changes.

This fixes a bug where you can't print a run that has flow_name = None.

How should this PR be tested?

from sklearn import ensemble
from openml import tasks, flows, runs
import openml

task = tasks.get_task(3954)
clf = ensemble.RandomForestClassifier()
flow = flows.sklearn_to_flow(clf)
run = runs.run_flow_on_task(task, flow)
print(run)  #should print w/o error

@ledell ledell changed the base branch from master to develop September 22, 2018 13:38
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mfeurer mfeurer merged commit d3215c0 into openml:develop Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Printing the result of a run gives an error when flow_name is None

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.