MAINT bump required liac-arff version#427
Merged
mfeurer merged 2 commits intodevelopopenml/openml-python:developfrom Mar 29, 2018
maint/bump_liac_arff_dependencyopenml/openml-python:maint/bump_liac_arff_dependencyCopy head branch name to clipboard
Merged
MAINT bump required liac-arff version#427mfeurer merged 2 commits intodevelopopenml/openml-python:developfrom maint/bump_liac_arff_dependencyopenml/openml-python:maint/bump_liac_arff_dependencyCopy head branch name to clipboard
mfeurer merged 2 commits intodevelopopenml/openml-python:developfrom
maint/bump_liac_arff_dependencyopenml/openml-python:maint/bump_liac_arff_dependencyCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #427 +/- ##
==========================================
+ Coverage 89.37% 89.5% +0.12%
==========================================
Files 32 32
Lines 2683 2744 +61
==========================================
+ Hits 2398 2456 +58
- Misses 285 288 +3
Continue to review full report at Codecov.
|
janvanrijn
approved these changes
Mar 29, 2018
Member
janvanrijn
left a comment
There was a problem hiding this comment.
Seems like you're also maintaining the liac-arff library
Collaborator
Author
|
Yep... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version is more resilient with respect to commas in data. However, it cannot yet read all commas, that's for the future.