Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

WIP dataset Tagging#355

Merged
amueller merged 3 commits intoopenml:developopenml/openml-python:developfrom
amueller:taggingamueller/openml-python:taggingCopy head branch name to clipboard
Oct 12, 2017
Merged

WIP dataset Tagging#355
amueller merged 3 commits intoopenml:developopenml/openml-python:developfrom
amueller:taggingamueller/openml-python:taggingCopy head branch name to clipboard

Conversation

@amueller
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 12, 2017

Codecov Report

Merging #355 into develop will increase coverage by 0.08%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
+ Coverage    89.69%   89.77%   +0.08%     
===========================================
  Files           32       32              
  Lines         2522     2542      +20     
===========================================
+ Hits          2262     2282      +20     
  Misses         260      260
Impacted Files Coverage 螖
openml/_api_calls.py 90.27% <100%> (+0.27%) 猬嗭笍
openml/datasets/functions.py 90.19% <100%> (+0.14%) 猬嗭笍
openml/exceptions.py 100% <100%> (酶) 猬嗭笍
openml/datasets/dataset.py 80% <70%> (+1.14%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e01ef40...96a850b. Read the comment docs.


Parameters
----------
tag : string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be str?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes


Parameters
----------
tag : string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@amueller amueller merged commit d05790b into openml:develop Oct 12, 2017
@mfeurer mfeurer mentioned this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.