Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Cast data qualities to float#353

Merged
amueller merged 1 commit intodevelopopenml/openml-python:developfrom
fix_345openml/openml-python:fix_345Copy head branch name to clipboard
Oct 12, 2017
Merged

Cast data qualities to float#353
amueller merged 1 commit intodevelopopenml/openml-python:developfrom
fix_345openml/openml-python:fix_345Copy head branch name to clipboard

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Oct 12, 2017

Fixes #345.

@codecov-io
Copy link

codecov-io commented Oct 12, 2017

Codecov Report

Merging #353 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #353      +/-   ##
==========================================
+ Coverage    89.69%   89.9%   +0.21%     
==========================================
  Files           32      32              
  Lines         2522    2626     +104     
==========================================
+ Hits          2262    2361      +99     
- Misses         260     265       +5
Impacted Files Coverage 螖
openml/datasets/functions.py 91.52% <100%> (+1.47%) 猬嗭笍
openml/datasets/dataset.py 79.57% <100%> (+0.71%) 猬嗭笍
openml/tasks/functions.py 87.55% <0%> (+1.66%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e01ef40...aa758f9. Read the comment docs.

@amueller
Copy link
Contributor

I'd argue the xsd is wrong? Semantically they are not floats, right?

@amueller
Copy link
Contributor

I'd say this is better then before but still kinda stupid ;)

@mfeurer
Copy link
Collaborator Author

mfeurer commented Oct 12, 2017

Some qualities are floats, but some aren't. And except for writing down which to cast as int I wouldn't how to do this.

@amueller amueller merged commit 6b22bb6 into develop Oct 12, 2017
@mfeurer mfeurer deleted the fix_345 branch October 15, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.