[ENH] V1 → V2 API Migration - evaluation measures#1603
[ENH] V1 → V2 API Migration - evaluation measures#1603PGijsbers merged 249 commits intoopenml:mainopenml/openml-python:mainfrom EmanAbdelhaleem:evaluation-measures-migEmanAbdelhaleem/openml-python:evaluation-measures-migCopy head branch name to clipboard
Conversation
…into issue1564
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1603 +/- ##
==========================================
- Coverage 53.96% 53.75% -0.22%
==========================================
Files 61 61
Lines 5051 5062 +11
==========================================
- Hits 2726 2721 -5
- Misses 2325 2341 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #1593
Depends on #1576
Related to #1575
geetu040
left a comment
There was a problem hiding this comment.
update with #1576 (comment)
geetu040
left a comment
There was a problem hiding this comment.
@EmanAbdelhaleem Thanks for the PR. Nicely done!
I have updated the PR to sync with latest changes in base PR.
@PGijsbers please review/merge.
PGijsbers
left a comment
There was a problem hiding this comment.
Generally looks good to me, minor changes for the tests. Also holding off for a second due to the CI failures that Armaghan is investigating.
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
openml#1603 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
|
@PGijsbers I've updated the PR with your suggested changes and the only failing test is sporadic. This should be ready for review/merge. |
Fixes #1593
Depends on #1576
Related to #1575
Details
This PR implements
EvaluationMeasuresresource, and refactor its existing functions