refactor: Deprecate array formats and default to dataframe#1372
Merged
LennartPurucker merged 26 commits intodevelopopenml/openml-python:developfrom Jun 17, 2025
refactor-default-dataframeopenml/openml-python:refactor-default-dataframeCopy head branch name to clipboard
Merged
refactor: Deprecate array formats and default to dataframe#1372LennartPurucker merged 26 commits intodevelopopenml/openml-python:developfrom refactor-default-dataframeopenml/openml-python:refactor-default-dataframeCopy head branch name to clipboard
LennartPurucker merged 26 commits intodevelopopenml/openml-python:developfrom
refactor-default-dataframeopenml/openml-python:refactor-default-dataframeCopy head branch name to clipboard
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1372 +/- ##
===========================================
- Coverage 84.33% 84.18% -0.16%
===========================================
Files 38 38
Lines 5325 5230 -95
===========================================
- Hits 4491 4403 -88
+ Misses 834 827 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53e3cec to
6296f37
Compare
SubhadityaMukherjee
previously approved these changes
Apr 1, 2025
Contributor
SubhadityaMukherjee
left a comment
There was a problem hiding this comment.
Okay looks good to me now. Merge conflicts were fixed, target_names was renamed back to target since I could not find a reason to change it everywhere.
Contributor
|
I am not confident in trying to merge it to develop until the tests are up and running again. |
I am not confident in trying to merge it to develop until the tests are up and running again.
Contributor
LennartPurucker
left a comment
There was a problem hiding this comment.
Did one full pass, LGTM, now looking into tests
PGijsbers
reviewed
Jun 17, 2025
PGijsbers
requested changes
Jun 17, 2025
Collaborator
PGijsbers
left a comment
There was a problem hiding this comment.
Pretty much fine to merge
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
…to refactor-default-dataframe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP