ux: Provide helpful link to documentation when error due to missing API token#1364
Merged
LennartPurucker merged 7 commits intodevelopopenml/openml-python:developfrom Oct 17, 2024
feat-better-error-message-for-no-api-keyopenml/openml-python:feat-better-error-message-for-no-api-keyCopy head branch name to clipboard
Merged
ux: Provide helpful link to documentation when error due to missing API token#1364LennartPurucker merged 7 commits intodevelopopenml/openml-python:developfrom feat-better-error-message-for-no-api-keyopenml/openml-python:feat-better-error-message-for-no-api-keyCopy head branch name to clipboard
LennartPurucker merged 7 commits intodevelopopenml/openml-python:developfrom
feat-better-error-message-for-no-api-keyopenml/openml-python:feat-better-error-message-for-no-api-keyCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1364 +/- ##
===========================================
+ Coverage 84.19% 84.34% +0.14%
===========================================
Files 38 38
Lines 5303 5315 +12
===========================================
+ Hits 4465 4483 +18
+ Misses 838 832 -6 ☔ View full report in Codecov by Sentry. |
1a1049d to
2a66b51
Compare
PGijsbers
requested changes
Oct 15, 2024
Collaborator
PGijsbers
left a comment
There was a problem hiding this comment.
minor change to text 📖
LennartPurucker
approved these changes
Oct 15, 2024
Contributor
LennartPurucker
left a comment
There was a problem hiding this comment.
If test pass, LGTM!
502ce27 to
0bbd67d
Compare
LennartPurucker
requested changes
Oct 17, 2024
Contributor
LennartPurucker
left a comment
There was a problem hiding this comment.
Print statements, huh?
Collaborator
Author
|
Was debugging with it xx, it's not ready yet, still some errors it seems |
bfd485d to
a845535
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply provides a direct link to the following whenever there is an error with a specific code (search "provide API key") when requesting to an endpoint.
Link given: https://openml.github.io/openml-python/main/examples/20_basic/introduction_tutorial.html#authentication
EDIT: Also found out that some
autousefixtures were not being triggered ifpytestwas only being called on a particular file. I moved theseautousefixtures intotests/conftest.pywhich means they will now be triggered.Also I required temporarily disabling the
"apikey"in the config, hence there was a small context manager added to enable this behaviour.