Test Fixes for v0.15.1#1358
Test Fixes for v0.15.1#1358eddiebergman merged 9 commits intodevelopopenml/openml-python:developfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1358 +/- ##
===========================================
+ Coverage 81.71% 84.37% +2.66%
===========================================
Files 38 38
Lines 5261 5262 +1
===========================================
+ Hits 4299 4440 +141
+ Misses 962 822 -140 ☔ View full report in Codecov by Sentry. |
eddiebergman
left a comment
There was a problem hiding this comment.
You waste my time reviewing this near perfect code, how dare you? There's a merge button you can just press you know, I will find you, I will visit you, and... I will waste your time...
Oh but also can you fix the logging of can't create the config_dir as discussed xx
eddiebergman
left a comment
There was a problem hiding this comment.
You didn't even request a review from me after making the changes, it's like you're trying to waste not only my time, but your time and everyone elses time who now has to read this laboriously but lovingly crafted collection of letters assembled into a structure known as a paragraph.
I hope you're happy... but yeah LGTM
Minor fixes to tests to make them work (again).