Pin NumPy to be lower than 2.0#1344
Closed
knyazer wants to merge 1 commit intoopenml:developopenml/openml-python:developfrom
Closed
Pin NumPy to be lower than 2.0#1344knyazer wants to merge 1 commit intoopenml:developopenml/openml-python:developfrom
knyazer wants to merge 1 commit intoopenml:developopenml/openml-python:developfrom
Conversation
Fixes ```AttributeError: `np.sctypes` was removed in the NumPy 2.0 release. Access dtypes explicitly instead.. Did you mean: 'dtypes'?``` on newer NumPy versions
Collaborator
|
Did you try yet to install from GitHub? The develop branch should already be numpy 2.0 compatible: #1341 |
Contributor
Author
|
No, I actually did not :( Yep, it works on the development version. Annoying that it is not yet on the pypi. Sorry for the noise, then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
AttributeError: `np.sctypes` was removed in the NumPy 2.0 release.on newer NumPy versions and poetry installationReference Issue
None
What does this PR implement/fix? Explain your changes.
Fixes the
in the
sklearnextension. (line 53,sklearn/extension.py)You might say "but nobody has ever experienced this issue!". True. For some reason, pip can figure out that the dependency should be lower than 2.0; I don't how it does it. However, I use poetry as a package manager, and if installing openml via poetry, it uses numpy 2.1 as a dependency, which breaks openml.
How should this PR be tested?
Install poetry. Then:
This would throw before the changes, but would not after the changes.
Any other comments?
Should be pretty easy to merge.