Update more sklearn tests#1175
Merged
PGijsbers merged 4 commits intodevelopopenml/openml-python:developfrom Oct 24, 2022
update_more_sklearn_testsopenml/openml-python:update_more_sklearn_testsCopy head branch name to clipboard
Merged
Update more sklearn tests#1175PGijsbers merged 4 commits intodevelopopenml/openml-python:developfrom update_more_sklearn_testsopenml/openml-python:update_more_sklearn_testsCopy head branch name to clipboard
PGijsbers merged 4 commits intodevelopopenml/openml-python:developfrom
update_more_sklearn_testsopenml/openml-python:update_more_sklearn_testsCopy head branch name to clipboard
Conversation
mfeurer
approved these changes
Oct 24, 2022
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* n_iter is now keyword-only * Standardize sklearn pipeline description lookups * `priors` is no longer positional, and wasn't used in the first place * Remove loss=kneighbours from the complex pipelin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the full sklearn extension suite passes.
test_deserialize_complex_with_defaults: it seemed like it was passed as thelossfunction hyperparameter to boosting. Positional parameters are now generally disallowed, which is why this failed. However,KNeighbourswas not a valid value forlossin the first place, it just never noticed because we don't execute the pipeline at any point. It seemed more appropriate to remove this step of the pipeline.test_run_model_on_fold_classification_3: the priors hyperparameter was never used withHardNaiveBayes, so I simply removed it and relied on the inheritance. It seemed cleaner that way, unless there was a purpose? Either way it needed refactoring because positionals were not allowed.