Fix/1110#1117
Conversation
Publish explicitly empty suites and downloading any empty suites not currently supported.
Collaborator
Author
|
I ran unit tests locally, and the |
mfeurer
approved these changes
Oct 27, 2021
Co-authored-by: Matthias Feurer <feurerm@informatik.uni-freiburg.de>
Since unit test cleanup mechanism should take care of that.
mfeurer
approved these changes
Oct 27, 2021
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
Update function signatures for create_study|suite and allow for empty studies (i.e. with no runs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
create_study(fixes #1110):aliasparameter is now optionalrun_idsis allowed to be an empty list orNone(it is possible to create an empty study and upload runs to attach to it later). Internally[]will be converted toNone, otherwise the server gets upset (see Make optional arguments tocreate_studyactually optional聽#1110 for more info).Note that previously empty studies were not allowed in
openml-python, but they now are. Previously empty studies were only allowed if they were created before2019-01-01, and they were expected to have theirrunsset toNoneso I reintroduced this convention for new studies without runs (though I think perhaps an empty list might be better).