Use new slice_plot function from OpenMC#172
Draft
paulromano wants to merge 4 commits intoopenmc-dev:developopenmc-dev/plotter:developfrom
paulromano:use-slice-plot-apipaulromano/plotter:use-slice-plot-apiCopy head branch name to clipboard
Draft
Use new slice_plot function from OpenMC#172paulromano wants to merge 4 commits intoopenmc-dev:developopenmc-dev/plotter:developfrom paulromano:use-slice-plot-apipaulromano/plotter:use-slice-plot-apiCopy head branch name to clipboard
slice_plot function from OpenMC#172paulromano wants to merge 4 commits intoopenmc-dev:developopenmc-dev/plotter:developfrom
paulromano:use-slice-plot-apipaulromano/plotter:use-slice-plot-apiCopy head branch name to clipboard
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the calls to
id_mapandproperty_mapwith the singleslice_plotfunction introduced in openmc-dev/openmc#3806. The filter binning capability is currently only utilized forMeshMaterialFilterbut with some more refactoring, we should be able to use it for all spatial tally filters, which will remove a lot of code inPlotModel.