processing all reactions for ENDF 7.1 chain file#84
processing all reactions for ENDF 7.1 chain file#84shimwell wants to merge 1 commit intomasteropenmc-dev/data:masterfrom adding_more_reactions_to_chainopenmc-dev/data:adding_more_reactions_to_chainCopy head branch name to clipboard
Conversation
|
@shimwell Despite my comments in #83, I don't recommend that we add all reactions right now. Currently, including all reactions is going to result in very high memory usage for depletion calculations because OpenMC will create reaction rate tallies for every reaction present. The first thing we need is a way for the reactions to be configured when running a depletion calculation (i.e., one can specify a subset of the reactions to be included). |
|
Yes that makes sense, I guess we come back to this PR in the future. In the meantime I'm going to run a few of depletion simulations and see how much RAM is needed for my own specific cases. In one case I just have an Al27 vessel as the only depletable material. So that might not need too much RAM. I see that Al reactions go from 4 to 15 so it should give me a better answer. to |
as mentioned in issue #83 it is perhaps best to include all the reactions in the chain files
This PR adds a arguments to the processing script when it calls
chain.from_endfso that all the reactions are included in the chain fileI am going to implement these changes over on my fork that has evolved into a package 😄 as well but wanted to help keep this repo up to date