fix: ensure default telemetry attributes are sent #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (33.07%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
============================================
+ Coverage 32.86% 33.07% +0.21%
- Complexity 974 984 +10
============================================
Files 182 182
Lines 6880 6896 +16
Branches 764 769 +5
============================================
+ Hits 2261 2281 +20
+ Misses 4512 4509 -3
+ Partials 107 106 -1 ☔ View full report in Codecov by Sentry. |
e3f0f5b to
13324c2
Compare
13324c2 to
421b5c5
Compare
jimmyjames
commented
Feb 18, 2025
jimmyjames
commented
Feb 18, 2025
evansims
approved these changes
Feb 18, 2025
rhamzeh
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no telemetry is explicitly configured, record the default metrics and attributes.
Description
Currently, if telemetry is not explicitly configured by a customer, no attributes are sent with the default metrics.
This change ensures that the documented default attributes are sent along with the metrics if no telemetry configuration was provided. If there is a provided telemetry configuration, we will use that. It also update
Metricsto only create a histogram/counter if it is configured in thetelemetryConfiguration.Added unit tests for the above scenarios, as well as verified in the example application that the default attributes are sent if there is no configuration, and that the metrics are not set if not configured.
References
Review Checklist
main