Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: Align code generated from sdk-generator #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhamzeh merged 1 commit into from
Jan 22, 2025
Merged

feat: Align code generated from sdk-generator #137

rhamzeh merged 1 commit into from
Jan 22, 2025

Conversation

@piotrooo
Copy link
Contributor

@piotrooo piotrooo commented Jan 21, 2025

Description

Generate code form the aligned sdk-generator.

References

This is the next step connected with openfga/sdk-generator#470.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@piotrooo piotrooo requested review from a team as code owners January 21, 2025 19:49
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 3.15315% with 430 lines in your changes missing coverage. Please review.

Project coverage is 29.82%. Comparing base (3d899d1) to head (9bc69f0).

Files with missing lines Patch % Lines
...a/dev/openfga/sdk/api/model/BatchCheckRequest.java 0.00% 72 Missing ⚠️
...java/dev/openfga/sdk/api/model/BatchCheckItem.java 0.00% 68 Missing ⚠️
...ain/java/dev/openfga/sdk/api/model/CheckError.java 0.00% 61 Missing ⚠️
...a/dev/openfga/sdk/api/model/ForbiddenResponse.java 0.00% 49 Missing ⚠️
.../dev/openfga/sdk/api/model/BatchCheckResponse.java 0.00% 48 Missing ⚠️
.../openfga/sdk/api/model/BatchCheckSingleResult.java 0.00% 46 Missing ⚠️
...main/java/dev/openfga/sdk/api/model/Assertion.java 8.33% 33 Missing ⚠️
.../java/dev/openfga/sdk/api/model/AuthErrorCode.java 0.00% 23 Missing ⚠️
src/main/java/dev/openfga/sdk/api/OpenFgaApi.java 15.78% 16 Missing ⚠️
.../java/dev/openfga/sdk/api/model/ExpandRequest.java 7.69% 12 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
- Coverage     31.72%   29.82%   -1.90%     
- Complexity      885      890       +5     
============================================
  Files           169      176       +7     
  Lines          6311     6746     +435     
  Branches        699      756      +57     
============================================
+ Hits           2002     2012      +10     
- Misses         4207     4632     +425     
  Partials        102      102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh
Copy link
Member

rhamzeh commented Jan 22, 2025

Thanks for doing this @piotrooo!

Just a heads up that we usually try to split off community contributions into their own commit and mark them as a git author for attribution.

In this case, considering the change was only in docs (I'm thinking of this one) I think we're OK - and will merge!

@rhamzeh rhamzeh added this pull request to the merge queue Jan 22, 2025
Merged via the queue into openfga:main with commit d69e701 Jan 22, 2025
11 checks passed
@piotrooo piotrooo deleted the feature/align-version branch January 22, 2025 15:39
@jimmyjames jimmyjames mentioned this pull request Feb 7, 2025
Merged
4 tasks
@dyeam0 dyeam0 mentioned this pull request Oct 8, 2025
Closed
6 tasks
@dyeam0 dyeam0 linked an issue Oct 8, 2025 that may be closed by this pull request
Support Changelog Filter by Time #156
Closed
1 task
@dyeam0 dyeam0 mentioned this pull request Oct 8, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Changelog Filter by Time

3 participants

@piotrooo @codecov-commenter @rhamzeh
Morty Proxy This is a proxified and sanitized view of the page, visit original site.