Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

imgproc: vectorize cv::createHanningWindow #27368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 4.x
Choose a base branch
Loading
from
Draft

imgproc: vectorize cv::createHanningWindow #27368

wants to merge 1 commit into from
+57 −4

Conversation

fengyuentau
Copy link
Member

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added this to the 4.12.0 milestone May 27, 2025
@fengyuentau fengyuentau requested a review from asmorkalov May 27, 2025 12:12
@fengyuentau
Copy link
Member Author

Performance testing results:

  • K1

GCC

                       Name of Test                        base-gcc patch-gcc patch-gcc 
                                                                                  vs    
                                                                               base-gcc 
                                                                              (x-factor)
CreateHanningWindow::CreateHanningWindowFixture::640x480    1.285     1.064      1.21   
CreateHanningWindow::CreateHanningWindowFixture::1920x1080  7.985     6.747      1.18

Clang

                       Name of Test                        base-clang patch-clang patch-clang
                                                                                      vs     
                                                                                  base-clang 
                                                                                  (x-factor) 
CreateHanningWindow::CreateHanningWindowFixture::640x480     1.023       0.935       1.09    
CreateHanningWindow::CreateHanningWindowFixture::1920x1080   6.401       5.878       1.09
  • RK3568
                       Name of Test                        rk-base rk-patch  rk-patch 
                                                                                vs    
                                                                             rk-base  
                                                                            (x-factor)
CreateHanningWindow::CreateHanningWindowFixture::640x480    1.355   1.513      0.90   
CreateHanningWindow::CreateHanningWindowFixture::1920x1080  9.212   10.376     0.89

@fengyuentau fengyuentau marked this pull request as draft May 27, 2025 12:20
@fengyuentau fengyuentau removed this from the 4.12.0 milestone May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees
No one assigned
Labels
category: imgproc optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fengyuentau
Morty Proxy This is a proxified and sanitized view of the page, visit original site.